doc,build,win: update docs with clang #57991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated BUILDING.md to make ClangCL mandatory for new versions of Node. Forcing clang-cl flag in vcbuild if not specified, thus disabling MSVC.
StefanStojanovic
added
doc
nodejs-github-bot
added
needs-ci
richardlau
added
dont-land-on-v18.x
dont-land-on-v20.x
richardlau
approved these changes
Apr 23, 2025
joyeecheung
approved these changes
Apr 23, 2025
lpinca
approved these changes
Apr 23, 2025
Co-authored-by: Joyee Cheung <[email protected]>
joyeecheung
approved these changes
Apr 24, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57991 ✔ Done loading data for nodejs/node/pull/57991 ----------------------------------- PR info ------------------------------------ Title doc,build,win: update docs with clang (#57991) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch StefanStojanovic:mefi-clang-doc -> nodejs:main Labels doc, windows, build, tools, needs-ci, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 2 - doc,build,win: update docs with clang - Update vcbuild.bat Committers 2 - StefanStojanovic <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57991 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57991 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 23 Apr 2025 14:06:54 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57991#pullrequestreview-2787527994 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/57991#pullrequestreview-2791118510 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57991#pullrequestreview-2788669874 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-28T14:55:52Z: https://ci.nodejs.org/job/node-test-pull-request/66501/ - Querying data for job/node-test-pull-request/66501/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 57991 From https://github.com/nodejs/node * branch refs/pull/57991/merge -> FETCH_HEAD ✔ Fetched commits as a7cbb9047455..f8bce751bbbd -------------------------------------------------------------------------------- Auto-merging BUILDING.md [main 49114546ed] doc,build,win: update docs with clang Author: StefanStojanovic <[email protected]> Date: Wed Apr 23 12:53:31 2025 +0200 3 files changed, 13 insertions(+), 9 deletions(-) [main 2f0886cb01] Update vcbuild.bat Author: Stefan Stojanovic <[email protected]> Date: Thu Apr 24 09:38:46 2025 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc,build,win: update docs with clanghttps://github.com/nodejs/node/actions/runs/14748719324 |
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2244a09 |
|
I guess this should be included into the 24 release and also part of the notable changes there. |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
Updated BUILDING.md to make ClangCL mandatory for new versions of Node. Forcing clang-cl flag in vcbuild if not specified, thus disabling MSVC. PR-URL: #57991 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
Updated BUILDING.md to make ClangCL mandatory for new versions of Node. Forcing clang-cl flag in vcbuild if not specified, thus disabling MSVC. PR-URL: #57991 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the documentation to fit the new compiler on Windows - ClangCL. The main focus is the
BUILDING.mdfile. All threeWindows Prerequisitessections are updated to reflect the compiler change (WinGet configuration already supported it, so no changes there).In addition, there are changes to
vcbuild.batto add theclang-clflag for Node.js v24+ even if not provided. Since v24 will include #57753 (or some other V8 update), compiling with MSVC will result in errors, so IMHO, there is not much use in allowing MSVC compilation at all, although I'm open to suggestions and different opinions on this.